Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missed changes: copy temp files instead of move, crate use formatting #223

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

lancelui-amzn
Copy link
Contributor

Description of changes:

  • Java profile now copies instead of moving the flamegraph files from the temp directory to the record directory. This makes aperf the owner of the file.
  • Reformatted PMU module imports.

Testing:

Ran on AMD instances and checked for perf_stat collecting events. Profiled JVMs and verified ownership matches the user who ran aperf.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lancelui-amzn lancelui-amzn requested a review from a team as a code owner August 9, 2024 20:26
@janaknat janaknat merged commit 039d598 into aws:main Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants